feat: PLG-131 - custom context banner#42
Merged
pleberre merged 5 commits intorelease/2.6.2from Feb 10, 2026
Merged
Conversation
There was a problem hiding this comment.
2 issues found across 14 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="includes/classes/models/class-plugins.php">
<violation number="1" location="includes/classes/models/class-plugins.php:427">
P2: Missing fallback to 'default' key in JSON. The docblock documents support for `{"default": "...", "fr": "..."}` format, but the implementation returns empty string when the requested language doesn't exist instead of falling back to `$decoded['default']`.</violation>
</file>
<file name="templates/admin/common/fields/toggle.php">
<violation number="1" location="templates/admin/common/fields/toggle.php:19">
P1: Using `hidden` (display: none) on the checkbox breaks keyboard accessibility. Users cannot Tab to this toggle control. Use `sr-only` or keep the visually-hidden-but-accessible pattern instead.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces customizable consent banner placeholders for blocked shortcodes with full i18n (internationalization) support, along with UX improvements for the extension subpage.
Features
Summary by cubic
Introduces a customizable, multilingual consent banner for blocked shortcodes and improves the extension subpage UX.
New Features
Migration
Written for commit f4f3193. Summary will update on new commits.