This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Add chinese fonts to the web toolkit #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes double to single quotes for the font family update
Contributor
|
Hi Pascal! I'm wondering, are these system fonts? |
Contributor
Author
|
@davidknezic yes. that's why we have to provide a selection (OSX, Win). Chinese Webfonts are not a real thing sadly, the amount of characters needed breaks every pageload performance (multiple MB for one font). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the standard simplified and traditional Chinese fonts to the toolkit.
Change for the global guidelines has been submitted to.