fix: use innerHTML instead of textContent in createElement helper#92
Open
simgunz wants to merge 1 commit intoawslabs:devfrom
Open
fix: use innerHTML instead of textContent in createElement helper#92simgunz wants to merge 1 commit intoawslabs:devfrom
simgunz wants to merge 1 commit intoawslabs:devfrom
Conversation
The createElement helper named its third parameter 'innerHTML' but assigned it via textContent, causing HTML strings (filter controls, table rows, PDF navigation) to render as escaped text instead of being interpreted as HTML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The
createElementutility inmain.jsnames its third parameterinnerHTMLbut assigns it viael.textContent, which escapes HTML. This causes dynamically injected elements (report filter controls, non-match table rows, PDF navigation buttons) to render as raw HTML strings instead of interactive UI components.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Before the fix:
