Fix: include static assets in package distribution#91
Open
simgunz wants to merge 1 commit intoawslabs:devfrom
Open
Fix: include static assets in package distribution#91simgunz wants to merge 1 commit intoawslabs:devfrom
simgunz wants to merge 1 commit intoawslabs:devfrom
Conversation
The HTML report styling and interactive JS files were not included in the built wheel because setuptools only packages .py files by default. This resulted in unstyled HTML reports when installed from PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML reporter relies on
styling/style.cssandinteractive/main.jsat runtime, but setuptools only packages.pyfiles by default. When installed from PyPI, these files are missing, causing_get_basic_css()to returnNoneand rendering the HTML report without any styling.[tool.setuptools.package-data]topyproject.tomlto explicitly include.cssand.jsfilesCurrent rendering with the problem:
