Skip to content

feat: Add provision and deprovision DetailType#81

Open
daveroberts-aws wants to merge 4 commits intoawslabs:mainfrom
daveroberts-aws:DetailType
Open

feat: Add provision and deprovision DetailType#81
daveroberts-aws wants to merge 4 commits intoawslabs:mainfrom
daveroberts-aws:DetailType

Conversation

@daveroberts-aws
Copy link
Copy Markdown
Contributor

Issue # (if applicable)

N/A

Reason for this change

There are no DetailType values for provisioning and deprovisioning.

Stack de/provisioning and tenant on/offboarding can be mutually exclusive and we need to accommodate this.

For example, an application stack/cell may be de/provisioned as part of a scaling or migration activity without tenant on/offboarding.

Description of changes

Added PROVISION_REQUEST and DEPROVISION_REQUEST to DetailType and updated EventManager accordingly.

Description of how you validated changes

Normal testing of stack deployment. No changes to tests were required.

Checklist

  • [ x ] My code adheres to the CONTRIBUTING GUIDE
  • [ x ] I have updated the relevant documentation (if applicable).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@daveroberts-aws
Copy link
Copy Markdown
Contributor Author

I would also raise the topic of standardising the verb-age used in DetailType. Some use the infinitive, ie. PROVISION_, and others use the '-ing' form, ie. ONBOARDING_.

Comment thread src/utils/event-manager.ts Outdated
@suhussai
Copy link
Copy Markdown
Contributor

suhussai commented Aug 1, 2024

I would also raise the topic of standardising the verb-age used in DetailType. Some use the infinitive, ie. PROVISION__, and others use the '-ing' form, ie. ONBOARDING__.

+1 to this. This will also be a breaking change, but I think it's important.

Copy link
Copy Markdown
Contributor

@suhussai suhussai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor point on the extra comment line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants