feat: Add provision and deprovision DetailType#81
Open
daveroberts-aws wants to merge 4 commits intoawslabs:mainfrom
Open
feat: Add provision and deprovision DetailType#81daveroberts-aws wants to merge 4 commits intoawslabs:mainfrom
daveroberts-aws wants to merge 4 commits intoawslabs:mainfrom
Conversation
Contributor
Author
|
I would also raise the topic of standardising the verb-age used in DetailType. Some use the infinitive, ie. PROVISION_, and others use the '-ing' form, ie. ONBOARDING_. |
suhussai
reviewed
Aug 1, 2024
Contributor
+1 to this. This will also be a breaking change, but I think it's important. |
suhussai
approved these changes
Aug 2, 2024
Contributor
suhussai
left a comment
There was a problem hiding this comment.
Just a minor point on the extra comment line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
There are no DetailType values for provisioning and deprovisioning.
Stack de/provisioning and tenant on/offboarding can be mutually exclusive and we need to accommodate this.
For example, an application stack/cell may be de/provisioned as part of a scaling or migration activity without tenant on/offboarding.
Description of changes
Added PROVISION_REQUEST and DEPROVISION_REQUEST to DetailType and updated EventManager accordingly.
Description of how you validated changes
Normal testing of stack deployment. No changes to tests were required.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.