Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes AWS_OFI_NCCL_VERSION as an active version input because AWS OFI NCCL is now bundled with the EFA installer.
What changed
[README.md]
Marks AWS_OFI_NCCL_VERSION as deprecated.
Removes it from environment setup examples, docker build args, and image tag format.
Updates example test log description to no longer mention that variable.
[nccl-tests.Dockerfile]
Keeps ARG AWS_OFI_NCCL_VERSION only for backward compatibility, with value ignored.
Adds an explicit verification step to check libnccl-ofi.so exists under /opt/amazon/efa/lib/.