Add optional Training Plan support for HyperPod instance groups#1004
Open
newabdosheham wants to merge 9 commits intoawslabs:mainfrom
Open
Add optional Training Plan support for HyperPod instance groups#1004newabdosheham wants to merge 9 commits intoawslabs:mainfrom
newabdosheham wants to merge 9 commits intoawslabs:mainfrom
Conversation
Signed-off-by: Ankur Srivastava <awsankur@amazon.com>
Signed-off-by: Ankur Srivastava <awsankur@amazon.com>
* Change readme to refer to recent test cases & assets * Remove borked ascii logo
Description of changes: - Updating the CloudFormation template for the HyperPod Slurm observability stack. Now it automatically register Prometheus as the data-source for Grafana, and installs pre-configured dashboard to Grafana. - Updating lifecycle script to install metric exporters and OTEL collector in each node - more scalable architecture similar to the HyperPod EKS Observability. - Added "ObservabilityConfig" class in config.py. It has Prometheus Remote Write URL and advanced flag. For more details - https://catalog.workshops.aws/sagemaker-hyperpod/en-US/09-observability --------- Co-authored-by: Madhubalasri-B <madbal@amazon.com>
Author
|
This PR supersedes #930 (auto-closed due to upstream history rewrite). Addressing review feedback from #930:
Happy to adjust if you’d prefer a different naming/schema. |
Author
|
Hi @KeitaW @bluecrayon52 — thanks again for the guidance on #930. This PR (#1004) supersedes #930 (auto-closed due to upstream history rewrite) and is rebased onto the new main. It addresses the review feedback from #930 by: Standardizing instance_groups to a list of objects Embedding name in each instance group object Supporting Training Plans via optional per-group training_plan_arn (no global training-plan vars) Updating terraform.tfvars.example accordingly Would you mind taking a look when you have a moment? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why new PR: “Old PR #930 auto-closed due to upstream history rewrite; this is rebased onto new main.”
What changed: “Adds optional Training Plan support for HyperPod instance groups + HyperPod Slurm observability improvements.”