This repository was archived by the owner on May 13, 2021. It is now read-only.
Enable GovCloud and CN partitions (NOT COMPLETE)#23
Open
dacut wants to merge 14 commits intoawslabs:masterfrom
dacut:master
Open
Enable GovCloud and CN partitions (NOT COMPLETE)#23dacut wants to merge 14 commits intoawslabs:masterfrom dacut:master
dacut wants to merge 14 commits intoawslabs:masterfrom
dacut:master
Conversation
…gions in the partition.
|
The current solution also does not create an ipsec or ikev2 profile using the stronger encryption required by GovCloud (dh group14 and sha2; see https://docs.aws.amazon.com/govcloud-us/latest/UserGuide/govcloud-vpc.html). The csr config function parses these options but does not add another profile using them. Instead the |
|
Thanks for your contribution. This PR will be evaluated for the next version and we'll update to this thread once we have more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a significant refactor, and it's not complete -- there's a bucket this refers to, and I'm not sure who owns it.
Walking through the changes:
arn:aws:...toarn:${AWS::Partition}:....solutions-us-gov-west-1bucket containing thesolution-helper.zipfile for the Lambda function doesn't exist, pointed GovCloud at my personal version for now. This needs to be fixed.The incompleteness is the last step. We need to figure out who owns the
solutions-regionnamebuckets on the commerical partitions and get this replicated up into GovCloud and CN.