Fix bugs in MWAA verify_env: S3 client reference and missing json importFix/mwaa verify env#247
Open
eason1128 wants to merge 2 commits intoawslabs:masterfrom
Open
Fix bugs in MWAA verify_env: S3 client reference and missing json importFix/mwaa verify env#247eason1128 wants to merge 2 commits intoawslabs:masterfrom
eason1128 wants to merge 2 commits intoawslabs:masterfrom
Conversation
|
Also ran into the missing import: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two bugs in the MWAA verify_env tool:
Fixed incorrect S3 client reference in
airflow_verifier.py: Changeds3toself.s3in thedelete_file_from_dags_foldermethod call (line 286). The previous code would cause aNameErrorwhen users chose to delete the test DAG after running the full DAG run test.Added missing
jsonimport inutils.py: The module uses JSON functionality but was missing the import statement.Changes
s3toself.s3import jsonstatementTesting
Impact
These fixes ensure that: