Skip to content

Fix profile validation#214

Open
rusowyler wants to merge 1 commit intoawslabs:masterfrom
rusowyler:master
Open

Fix profile validation#214
rusowyler wants to merge 1 commit intoawslabs:masterfrom
rusowyler:master

Conversation

@rusowyler
Copy link

@rusowyler rusowyler commented Mar 14, 2023

Description of changes:

  • Correct the validation for the profile

    You can use letters, numbers, hyphens ( - ), and underscores ( _ ), but no spaces.

  • Added additional profile name validation alternatives to the tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution under the terms of your choice.

@calvin-c-stellantis
Copy link

Has this PR been merged? If not could you please merge?

Thanks a lot.

@iwamot
Copy link

iwamot commented May 9, 2023

I too wasted some time due to underscores not being allowed.

It seems to me that this PR should be merged immediately to avoid user confusion.

By the way, aws-sdk-java-v2 defines the following:

private static final Pattern VALID_IDENTIFIER = Pattern.compile("^[A-Za-z0-9_\\-/.%@:\\+]*$");

@ankon
Copy link

ankon commented Feb 16, 2026

Our profile names contain :, and the documentation doesn't anywhere say that that would be invalid: https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-files.html#cli-configure-files-using-profiles

It seems that this actually got merged (specifically in #246 / 305bc82), so: @CihanBosnali could you please double check the discussion here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments