Various fixes for MWAA verify_env.py script#206
Open
bishtawi wants to merge 2 commits intoawslabs:masterfrom
Open
Various fixes for MWAA verify_env.py script#206bishtawi wants to merge 2 commits intoawslabs:masterfrom
bishtawi wants to merge 2 commits intoawslabs:masterfrom
Conversation
4916ff5 to
9d32ea2
Compare
|
After submitting #208 I've found this one 😅 |
This was referenced Aug 25, 2022
|
On the check_vpc_service_endpoints there's another issue, you're checking if all the subnets of the vpc endpoint match the MWAA subnet ones, should be the opposite, check the MWAA subnets appear in VPC endpoint ones: vpc_endpoints = [endpoint for endpoint in vpc_endpoints if all(subnet in endpoint['SubnetIds'] for subnet in s_ids)] If not script is saying endpoints are not in the MWAA environment subnets and that's not true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
I was using this verify_env.py script to find issues with my MWAA environment that I brought up and found a few bugs with the script:
account_idvariableAnd while not technically a bug, I fixed a couple of instances where there was a function could return either a boolean or an empty string. As someone that prefers proper typing, I switched the empty string response to
False. I can revert this change if you want.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.