Feat/default codebuild image #787
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxie1999
force-pushed
the
feat/default_codebuild_image
branch
from
179349a to
164cfd2
Compare
sbkok
requested changes
Jun 21, 2025
Collaborator
sbkok
left a comment
sbkok
left a comment
There was a problem hiding this comment.
The CodeBuild Image was made a required property on purpose in ADF v4.0.
As setting a default image implies we need to release a major release to change it, as it would require introducing a breaking change.
Could you change this PR, or maybe better, open a new one for the CodeCommit account id optional change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Now in the deployment map, if the codebuild image does not explicitly defined in the deployment map, the deployment will fail. I would like to add define a default build image for the ADF.
What?
An easy fix is to define the default build image in the
src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/cdk/cdk_constructs/adf_codebuild.pyand set the build stage to optional in thesrc/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/schema_validation.py.Additionally,
account_idshould also be optional in the schema validation, as ADF 4.0 supports default source account id.