fix(identity): add missing utils.py and sys.path setup#1227
Open
madhununna wants to merge 1 commit intoawslabs:mainfrom
Open
fix(identity): add missing utils.py and sys.path setup#1227madhununna wants to merge 1 commit intoawslabs:mainfrom
madhununna wants to merge 1 commit intoawslabs:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Notebooks import setup_cognito_user_pool and reauthenticate_user from utils but no utils.py existed, causing ModuleNotFoundError. - Add shared utils.py to 03-AgentCore-identity/ with both functions - Add sys.path cell to the two 3LO notebooks that were missing it (inbound auth notebook already had the sys.path setup) Fixes awslabs#969
7d19f58 to
dc5c8ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #969
Concise description of the PR
Added missing
utils.pyto03-AgentCore-identity/and addedsys.pathsetup to two notebooks that were missing it, because all three identity tutorial notebooks importsetup_cognito_user_poolandreauthenticate_userfromutilsbut noutils.pyexisted in that directory.User experience
Before: Running any of the three identity tutorial notebooks fails immediately with
ModuleNotFoundError: No module named 'utils'before any code executes.After: The import succeeds and notebooks proceed normally past the setup cell.
Checklist
Notebooks import setup_cognito_user_pool and reauthenticate_user from utils but no utils.py existed, causing ModuleNotFoundError.
Fixes #969
Amazon Bedrock AgentCore Samples Pull Request
Important
review readylabel to it. Only PRs withreview readywill be reviewed.Issue number:
Concise description of the PR
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.