Fix version-based fallback for finding param group family #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort 1.4.x.x and newer engine versions
andreachild
reviewed
Jun 13, 2025
src/main/java/com/amazonaws/services/neptune/cluster/NeptuneClusterMetadata.java
Outdated
Show resolved
Hide resolved
andreachild
reviewed
Jun 13, 2025
src/test/java/com/amazonaws/services/neptune/cluster/NeptuneClusterMetadataTest.java
Outdated
Show resolved
Hide resolved
andreachild
reviewed
Jun 13, 2025
src/main/java/com/amazonaws/services/neptune/cluster/NeptuneClusterMetadata.java
Outdated
Show resolved
Hide resolved
andreachild
reviewed
Jun 13, 2025
src/test/java/com/amazonaws/services/neptune/cluster/NeptuneClusterMetadataTest.java
Outdated
Show resolved
Hide resolved
andreachild
reviewed
Jun 13, 2025
src/test/java/com/amazonaws/services/neptune/cluster/NeptuneClusterMetadataTest.java
Outdated
Show resolved
Hide resolved
andreachild
reviewed
Jun 13, 2025
src/test/java/com/amazonaws/services/neptune/cluster/NeptuneClusterMetadataTest.java
Outdated
Show resolved
Hide resolved
…usterMetadataTest.java Co-authored-by: andreachild <andrea.child@improving.com>
andreachild
reviewed
Jun 16, 2025
src/main/java/com/amazonaws/services/neptune/cluster/NeptuneClusterMetadata.java
Outdated
Show resolved
Hide resolved
andreachild
reviewed
Jun 16, 2025
src/test/java/com/amazonaws/services/neptune/cluster/NeptuneClusterMetadataTest.java
Outdated
Show resolved
Hide resolved
andreachild
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Neptune export primarily relies on a
DescribeDbClusterParameterGroupsrequest to determine the appropriate parameter group family for a cluster. There is however a fallback mechanism to infer it from the Neptune engine version. This fallback is primarily used in cases where the user does not have sufficient IAM permissions for theDescribeDbClusterParameterGroupsrequest.The existing version-based logic was sufficient for Neptune engine versions <= 1.3.x.x, although could not match parameter group families for neptune1.4 or newer. This logic is being updated to directly inject the major and minor versions into the parameter group family to better future proof for new Neptune versions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.