Skip to content

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Dec 17, 2025

Description

The composite structure of the Workspace component was fairly rigid and difficult to follow and change. I've taken it apart so it behaves more like a set of standard react components with styles.

This will make it easier to make changes to the navigation structure. This step was just to rework the structure, but not change any visuals or behavior.

  • Deconstruct the composite Workspace components
  • Renamed top bar components to NavBar
  • Moved sidebar related components to GraphExplorer module since that is the only place they are used
  • Sidebar now uses Radix Tabs component giving it better keyboard usability
  • Add PanelGroup which gives the inset card appearance to Panels which was originally what WorkspaceContent was doing

Validation

  • Smoke test at various browser sizes

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.17%. Comparing base (c5affc5) to head (ba4a35d).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
packages/graph-explorer/src/components/NavBar.tsx 0.00% 19 Missing and 23 partials ⚠️
...ckages/graph-explorer/src/components/Workspace.tsx 0.00% 5 Missing and 6 partials ⚠️
packages/graph-explorer/src/components/Panel.tsx 0.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1399       +/-   ##
===========================================
+ Coverage   47.81%   62.17%   +14.36%     
===========================================
  Files         382      306       -76     
  Lines        8525     6311     -2214     
  Branches     3159     2209      -950     
===========================================
- Hits         4076     3924      -152     
+ Misses       3070     1676     -1394     
+ Partials     1379      711      -668     
Flag Coverage Δ
unittests 62.17% <0.00%> (+14.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kmcginnes kmcginnes force-pushed the feature/remove-workspace branch from 826c6fa to 9cbf5a1 Compare December 17, 2025 22:29
@kmcginnes kmcginnes marked this pull request as ready for review December 17, 2025 22:30
@kmcginnes kmcginnes force-pushed the feature/remove-workspace branch from 9cbf5a1 to ba4a35d Compare December 18, 2025 00:02
@kmcginnes
Copy link
Collaborator Author

Rebased over color changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant