Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amazon alias:
@tylgross
Description of changes:
Removing
webrtc-adapterdecreases the size ofconnect-rtc-jsfrom193kbto121kb, about 37%.webrtc-adapterpatches prefixed versions of the WebRTC library and adds some other functionality, despite the fact that WebRTC is well-supported in all modern browsers and the API is stable. I couldn't find any evidence that connect is using experimental or semi-experimental portions of WebRTC APIs.In addition to this, Amazon Connect only supports the the last three major versions of Chrome, Firefox, and Firefox ESR. For these reasons, it makes sense to me to remove this dependency. Given that Connect has deprecated support for older browsers, I don't see this as a breaking change, but I don't think I'd argue if someone else thought it was.
If this change is considered too risky, an alternative might be to update to version 8 of
webrtc-adapter, which still saves about 20kb.Web RTC Support
Side note:
The support matrix here is partially incorrect in that Samsung Internet (being a fork of Chrome) fully supports unprefixed WebRTC.
From Device:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.