Skip to content

Conversation

@agdimech
Copy link
Contributor

Issue

N/A

Description

The Projen blueprint assumes yarn is used. If a user specifies an alternative package manager, yarn is still used.

Testing

Untested


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@agdimech agdimech added the DO NOT MERGE DO NOT MERGE label Nov 20, 2023
@agdimech
Copy link
Contributor Author

@alexforsyth - is projen-blueprint-component still used?

@alexforsyth
Copy link
Contributor

@agdimech it should be used? What do you mean?

I believe that component is the projen construct behind all of the packages/components/

@agdimech agdimech force-pushed the fix/pkg_mgr_support branch from caffe49 to 6939eb4 Compare December 5, 2023 05:05
@agdimech
Copy link
Contributor Author

agdimech commented Dec 5, 2023

@agdimech it should be used? What do you mean?

I believe that component is the projen construct behind all of the packages/components/

It looks like alot of the code is duplicated with https://github.com/aws/codecatalyst-blueprints/blob/main/packages/utils/projen-blueprint/src/blueprint.ts. Perhaps we should refactor into common code?

@agdimech agdimech force-pushed the fix/pkg_mgr_support branch from 6939eb4 to 8f97691 Compare December 5, 2023 06:04
@alexforsyth
Copy link
Contributor

The code between
(backs the blueprint codebase construct itself)
https://github.com/aws/codecatalyst-blueprints/blob/main/packages/utils/projen-blueprint/src/blueprint.ts

and
(backs the blueprint component codebase construct itself)
https://github.com/aws/codecatalyst-blueprints/blob/main/packages/utils/projen-blueprint-component/src/blueprint.ts

Is similar but its not exactly the same. You'll notice that components have a series of different commands they use to build themselves. For example, most of the blueprint publishing, etc, commands dont make sense for the components. The components are essentially minor upgrades across the typescript component.

See example usage here in the source repo component
https://github.com/aws/codecatalyst-blueprints/blob/main/packages/components/source-repositories/.projenrc.ts#L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE DO NOT MERGE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants