Fixed issue with logging suffix in user agent being duplicated #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#340
Description of changes:
In the recent release we updated to the SDK's new API for appending information to the logging API. There was an issue with the change that since logging library reuses the request object how the user agent string was being built it would duplicate the logging suffix on every request. This would work till the user agent it a size limit and then requests would start failing.
The fix is to add a check to make sure the suffix hasn't already been added before adding the logging suffix.
I tests this by first recreating with the user's code in the GitHub issue and the after the change confirming the user agent suffix is only added once.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.