Remove out of date packagerefence #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
added
the
Release Not Needed
GarrettBeatty
approved these changes
Oct 7, 2025
philasmar
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Release build failed because the sample project was reference 4.5.0 but the NLog appender is referencing 5.2.2 triggering a downgrade warning. And since warnings are treated as errors the release build fail. Since the sample project is referencing our NLog appender which already has a dependency on NLog we don't need this package reference on the sample at all. So to make maintenance easier in the future I removed the reference.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.