Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 3, 2025

When CDK apps grow extremely large (think 10-100 stacks, 1000-10000 constructs), all metadata together begins to exceed 512MB, the maximum string size in NodeJS. People usually deal with this by disabling metadata, but they shouldn't have to.

In addition, even for manifests that don't exceed 512MB the extremely large size of the single JSON object slows down its writing and reading every time, even if the metadata doesn't need to be accessed.

An effective solution is to write the metadata of an artifact to a separate file. This PR introduces the ability for that into the Cloud Assembly schema, and updates the CLI to read from both sources if available.

Removes an unused class from the refactoring project that we found through this project because it would have to be refactored. Rather than refactoring, bye-bye!

Relates to aws/aws-cdk#34480.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jun 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 3, 2025 13:21
@rix0rrr rix0rrr self-assigned this Jun 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.73%. Comparing base (78fa807) to head (c3494fe).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/cdk-toolkit.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   87.70%   87.73%   +0.02%     
==========================================
  Files          72       72              
  Lines       10095    10095              
  Branches     1331     1332       +1     
==========================================
+ Hits         8854     8857       +3     
+ Misses       1216     1213       -3     
  Partials       25       25              
Flag Coverage Δ
suite.unit 87.73% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rix0rrr rix0rrr marked this pull request as ready for review January 20, 2026 14:37
@rix0rrr rix0rrr changed the title feat(cli): metadata can live in a separate file (WIP) feat(cli): metadata can live in a separate file Jan 20, 2026
@rix0rrr rix0rrr requested a review from mrgrain January 22, 2026 11:58
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants