-
Notifications
You must be signed in to change notification settings - Fork 243
Add EFA Metrics to Container Insights #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR was marked stale due to lack of activity. |
| "container_efa_rdma_read_bytes", | ||
| "container_efa_rdma_write_bytes", | ||
| "container_efa_rdma_write_recv_bytes", | ||
| "container_efa_retrans_bytes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to update translation test aws/amazon-cloudwatch-agent/translator/tocwconfig/sampleConfig/emf_and_kubernetes_with_gpu_config.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does emf_and_kubernetes_with_gpu_high_frequency_config.yaml need to be updated too?
|
This PR was marked stale due to lack of activity. |
# Conflicts: # go.mod # go.sum
1e5bdf5 to
d3003b2
Compare
…EFA retrans metrics - Add container_efa_retrans_bytes, container_efa_retrans_pkts, container_efa_retrans_timeout_events, container_efa_impaired_remote_conn_events, container_efa_unresponsive_remote_events - Add corresponding pod and node EFA retrans metrics - Updates expected config to match recent EFA retrans metrics added in commit 30f0900
- Add container_efa_retrans_bytes, container_efa_retrans_pkts, container_efa_retrans_timeout_events, container_efa_impaired_remote_conn_events, container_efa_unresponsive_remote_events - Add corresponding pod and node EFA retrans metrics to test expectations - Fixes GenerateAwsEmfExporterConfigKubernetesWithHighFrequencyGPUMetrics test failure - Aligns test with EFA retrans metrics added in commit 30f0900
|
most recent commit passing: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/20173265214/job/57914630973 |
Blocked on amazon-contributing/opentelemetry-collector-contrib#385 before merging. will update go.mod after that PR has been merged in
Description of the issue
Elastic Fabric Adapter (EFA) is a network interface for Amazon EC2 instances that enables customers to run applications requiring high levels of inter-node communications at scale on AWS. EFA provides lower and more consistent latency and higher throughput than traditional TCP transport, making it ideal for high-performance computing (HPC), machine learning (ML) training, and other distributed workloads.
Currently, the CloudWatch Agent lacks visibility into some new EFA metrics, which are critical for:
Description of changes
This PR adds collection of five key EFA metrics at the node, container, and pod levels:
These metrics are collected from the Linux sysfs interface exposed by the EFA driver and are aggregated at:
The implementation reads hardware counters from the sysfs filesystem and exposes them through the CloudWatch Agent's container insights metrics pipeline.
Tests
Manual Testing:
vpc.amazonaws.com/efa: 1)Testing Configuration:
new integ test: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/19579639336/job/56074086384
The metrics were successfully published to CloudWatch and are queryable with appropriate dimensions (node, pod, container).