fix: require gateway when creating a gateway target#469
Merged
aidandaly24 merged 2 commits intofeat/gateway-integrationfrom Feb 27, 2026
Merged
fix: require gateway when creating a gateway target#469aidandaly24 merged 2 commits intofeat/gateway-integrationfrom
aidandaly24 merged 2 commits intofeat/gateway-integrationfrom
Conversation
A gateway target must always be attached to a gateway. Previously it was possible to create unassigned targets via "Skip for now" in the TUI or by omitting --gateway in non-interactive mode. - Validation now requires --gateway and verifies the gateway exists - TUI removes the "Skip for now" option from gateway selection - createExternalGatewayTarget rejects missing gateway at operations layer - Updated tests to cover all new validation paths
tejaskash
requested a deployment
to
e2e-testing
GitHub Actions
Waiting
Contributor
Coverage Report
|
aidandaly24
approved these changes
Feb 27, 2026
Contributor
aidandaly24
left a comment
aidandaly24
left a comment
There was a problem hiding this comment.
approved very clean change thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--gatewayin non-interactive mode--gateway, verifies the specified gateway exists, and errors early if no gateways are configured — with a helpful message directing users toagentcore add gatewayfirstNoGatewaysMessageblocks the flow when no gateways existcreateExternalGatewayTarget) rejects a missing gateway, removing theunassignedTargetscode pathTest plan
validate.test.ts— 3 new tests: missing--gateway, no gateways exist, specified gateway not foundcreate-mcp.test.ts— replaced unassigned-target tests with "throws when gateway not provided"gatewayfield and passagentcore add gateway-targetwithout a gateway configured → should erroragentcore add gateway-target --gateway nonexistent→ should list available gateways