fix: respect existing Cognito configuration during redeploy#42
Open
amitkumawat-node wants to merge 1 commit intoaws-samples:mainfrom
Open
fix: respect existing Cognito configuration during redeploy#42amitkumawat-node wants to merge 1 commit intoaws-samples:mainfrom
amitkumawat-node wants to merge 1 commit intoaws-samples:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where user-provided Cognito configuration is ignored during redeployments, causing a new User Pool to be created instead of reusing an existing one.
Problem
On initial deployment, a new Cognito User Pool is created as expected when no environment variables are provided.
However, on subsequent deployments, even when explicitly setting:
the script overrides this configuration based on stack detection logic and sets USE_EXISTING_COGNITO=false. As a result, a new Cognito User Pool is created on every run.
Root Cause
The deployment script prioritizes auto-detection logic over user-provided environment variables, leading to unintended overrides.
Changes
Behavior After Fix
Impact
Testing
Related Issue
Fixes #41