Skip to content

A few bugs fixed in 05-headless-browser and 10-mcp-server #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lesliesam wants to merge 3 commits into
base: main
Choose a base branch
from
Open

A few bugs fixed in 05-headless-browser and 10-mcp-server #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54f97c0
Add await for async function call.
May 5, 2025
e9e3dad
Fix the function params
May 6, 2025
14fb7ab
Fix the mcp server errors.
May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion JavaScript/05-headless-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ async function run() {
}

// Browser context content - safely get page info
const pageInfo = getPageInfo(page);
const pageInfo = await getPageInfo(page);
const browserContent = { text: `Current page: Title: '${pageInfo['title']}', URL: '${pageInfo['url']}'` };
printSystem(`Browser context: ${browserContent}`);

Expand Down
20 changes: 9 additions & 11 deletions JavaScript/10-mcp-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const sessionId = randomUUID();
fs.mkdirSync(`screenshots/${sessionId}/`, { recursive: true });
fs.mkdirSync(`artefacts/${sessionId}/`, { recursive: true });

function sleep(ms) {
async function sleep(ms) {
return new Promise(resolve => setTimeout(resolve, ms));
}

Expand Down Expand Up @@ -65,13 +65,13 @@ server.tool("type",
await page.keyboard.type(text);

if (submit) {
printSystem(`Pressing Enter to submit`);
console.log(`Pressing Enter to submit`);
await page.keyboard.press('Enter');
return { content: [{ type: "text", text: "submited" }] }
}
return { content: [{ type: "text", text: "not submited" }] }
} catch (error) {
printSystem(`Error typing text: ${error}`);
console.log(`Error typing text: ${error}`);
return { content: [{ type: "text", text: error.message }] }
}
}
Expand All @@ -82,13 +82,11 @@ server.tool("click",
x: z.number(),
y: z.number()
},
async ({ x, y }) => {
async ({x, y}) => {
await page.mouse.click(x, y);
sleep(1000);
await sleep(1000);

return {
clicked_at: { x, y }
};
return { content: [{ type: "text", text: `clicked at ${x},${y}` }] }
}
);

Expand All @@ -108,7 +106,7 @@ server.tool("scroll",

return { content: [{ type: "text", text: "not scrolled" }] }
}
sleep(1000);
await sleep(1000);

return { content: [{ type: "text", text: "scrolled" }] }
}
Expand All @@ -119,12 +117,12 @@ server.tool("writeFile",
filename: z.string(),
content: z.string()
},
async ({ url }) => {
async ({ filename, content }) => {
try {
fs.writeFileSync(`artefacts/${sessionId}/${filename}`, content, 'utf8');
return { content: [{ type: "text", text: filename }] }
} catch (error) {
printSystem(`Error writing file: ${error}`);
console.log(`Error writing file: ${error}`);
return { content: [{ type: "text", text: error.message }] }
}
}
Expand Down