adding makefile for further automation#17
Open
taherbs wants to merge 2 commits intoaws-samples:masterfrom
Open
adding makefile for further automation#17taherbs wants to merge 2 commits intoaws-samples:masterfrom
taherbs wants to merge 2 commits intoaws-samples:masterfrom
Conversation
…pdating the locust version
dalgibbard
reviewed
Feb 22, 2019
.env.sample
Outdated
| SERVICE_CNAME = "$(SERVICE_ENV)-taherbs-locust" | ||
| SERVICE_VPC = vpc-XXXXXX #Eb app VPC ID | ||
| SERVICE_EC2_SUBNETS = subnet-XXXXXX #Eb app EC2 subnets | ||
| SERVICE_ELB_SUBNESTS = subnet-XXXXXX #Eb app ALB subnets |
There was a problem hiding this comment.
Typo? SERVICE_ELB_SUBNESTS should be SERVICE_ELB_SUBNETS
dalgibbard
reviewed
Feb 22, 2019
Makefile
Outdated
| --branch_default $(SERVICE_ENV) \ | ||
| --vpc.id $(SERVICE_VPC) \ | ||
| --vpc.ec2subnets $(SERVICE_EC2_SUBNETS) \ | ||
| --vpc.elbsubnets $(SERVICE_ELB_SUBNESTS) \ |
There was a problem hiding this comment.
"NESTS" here too :) so at least it'd work, but should probably be corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made couple of modifications to make the deployment process more convenient:
Change logs: