This repository was archived by the owner on May 29, 2025. It is now read-only.
Open
Conversation
added 2 commits
August 9, 2019 12:26
…original version. Changed the mount point for the AMI, as it was mounting the wrong location, causing the ami ec2 instance to stall on boot. Changed the ecr registry region to use the default aws account region, as it had us-east-1 hardcoded
non-existent files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Changed isaac dockerfile base image, as isaac build was silently failing with original version (the ssm would mark the step as passed, despite failing every time). Changed the mount point for the AMI, as it was mounting the wrong location, causing the ami ec2 instance to stall on boot (reproduced multiple times, it would never pass the instance status checks). Changed the ecr registry region to use the default aws account region, as it had us-east-1 hardcoded which caused failures down the line if the user has their default aws region elsewhere.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.