Updates with working version of code

[puru-aws]

Issue , if available:

Description of changes:

*Issue #16
terraform get

README.md steps mentions the use of “terraform get” which is no more in use

---

- Tags argument usage

Usage of tags argument is incorrect, as the latest versions of terraform use an equals sign to assign values.

Error: Unsupported block type
│
│ on site/pub_priv_vpc.tf line 14, in resource "aws_vpc" "default":
│ 14: tags {
│
│ Blocks of type "tags" are not expected here. Did you mean to define argument "tags"? If so, use the equals sign to assign it a value.

The same errors occurs in :
site/webapp-sg.tf
site/nat-sg.tf
site/bastion-sg.tf
load_balancers/webapp-elb.tf

---

wait_for_elb_capacity usage is incorrect

Usage of wait_for_elb_capacity property in aws_autoscaling_group resource is incorrect.

Error: Incorrect attribute value type
│
│ on autoscaling_groups/webapp-asg.tf line 17, in resource "aws_autoscaling_group" "webapp_asg":
│ 17: wait_for_elb_capacity = false
│
│ Inappropriate value for attribute "wait_for_elb_capacity": number required.

---

Variables can be referenced without double quotes

All variables are referenced using ${} which is no longer needed.

---

Terraform destroy issue resolved

In the README step of destroying resources via Terraform, it has been mentioned due to this GitHub Issue, create_before_destroy lifecycle policy has to be manually changed to false in autoscaling_groups/webapp-asg.tf and launch_configurations/webapp-lc.tf files. Now this GitHub Issue seems to be closed, so recommended to test if the resources are destroyed via Terraform without this manual change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.