fix: prevent OSS policy name exceeding 32-char limit#686
Open
madhununna wants to merge 1 commit intoaws-samples:mainfrom
Open
fix: prevent OSS policy name exceeding 32-char limit#686madhununna wants to merge 1 commit intoaws-samples:mainfrom
madhununna wants to merge 1 commit intoaws-samples:mainfrom
Conversation
When policy_suffix defaulted to kb_name, policy names were constructed
as '{kb_name}-sp-{kb_name}', doubling the name and exceeding the 32-char
OpenSearch Serverless limit.
Fix uses self.suffix (already generated for uniqueness) as the default
policy_suffix, and truncates the kb_name prefix in policy names to
guarantee all generated names stay within the 32-char constraint.
Fixes aws-samples#582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:582
Description of changes:When policy_suffix defaulted to kb_name, policy names were constructed as '{kb_name}-sp-{kb_name}', doubling the name and exceeding the 32-char OpenSearch Serverless limit.
Fix uses self.suffix (already generated for uniqueness) as the default policy_suffix, and truncates the kb_name prefix in policy names to guarantee all generated names stay within the 32-char constraint.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.