Skip to content

Modyifying tag used when cloning and installing vllm-neuronx #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aws-eddy merged 1 commit into from
Dec 22, 2025
Merged

Modyifying tag used when cloning and installing vllm-neuronx #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vllm/inference/0.11.0/Dockerfile.neuronx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

# See http://bugs.python.org/issue19846
ENV LANG=C.UTF-8
ENV LD_LIBRARY_PATH=/opt/aws/neuron/lib:/lib/x86_64-linux-gnu:/opt/conda/lib/:$LD_LIBRARY_PATH

Check warning on line 18 in vllm/inference/0.11.0/Dockerfile.neuronx

View workflow job for this annotation

GitHub Actions / build (0.11.0, vllm/inference/0.11.0)

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$LD_LIBRARY_PATH'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
ENV PATH=/opt/conda/bin:/opt/aws/neuron/bin:$PATH

RUN apt-get update \
Expand Down Expand Up @@ -146,9 +146,9 @@

# Setting up APT and PIP repo for neuron artifacts
ARG NEURON_APT_REPO=apt.repos.neuron.amazonaws.com
ARG NEURON_APT_REPO_KEY

Check warning on line 149 in vllm/inference/0.11.0/Dockerfile.neuronx

View workflow job for this annotation

GitHub Actions / build (0.11.0, vllm/inference/0.11.0)

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NEURON_APT_REPO_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
ARG NEURON_PIP_REPO=pip.repos.neuron.amazonaws.com
ARG NEURON_PIP_REPO_KEY

Check warning on line 151 in vllm/inference/0.11.0/Dockerfile.neuronx

View workflow job for this annotation

GitHub Actions / build (0.11.0, vllm/inference/0.11.0)

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "NEURON_PIP_REPO_KEY")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
RUN mkdir -p /etc/apt/keyrings \
&& APT_REPO_PREFIX=$([ -n "${NEURON_APT_REPO_KEY}" ] && echo "${NEURON_APT_REPO_KEY}@" || echo "") \
&& echo "deb [signed-by=/etc/apt/keyrings/neuron.gpg] https://${APT_REPO_PREFIX}${NEURON_APT_REPO} jammy main" > /etc/apt/sources.list.d/neuron.list \
Expand All @@ -165,7 +165,7 @@

# vLLM branch names
ARG VLLM_PRIVATE_BRANCH=neuron-release-2.27
ARG VLLM_PUBLIC_BRANCH=0.2.1-lts
ARG VLLM_PUBLIC_BRANCH=0.2.1+lts

FROM base AS vllm-clone

Expand Down Expand Up @@ -219,7 +219,7 @@
&& apt-get clean

# Clone VLLM source before pip installations
RUN git clone -b ${VLLM_PUBLIC_BRANCH} https://github.com/vllm-project/vllm-neuron.git /opt/vllm
RUN git clone -b "${VLLM_PUBLIC_BRANCH}" https://github.com/vllm-project/vllm-neuron.git /opt/vllm

RUN PIP_REPO_URL=$([ -n "${NEURON_PIP_REPO_KEY}" ] && echo "https://${NEURON_PIP_REPO_KEY}@${NEURON_PIP_REPO}" || echo "https://${NEURON_PIP_REPO}") \
&& ${PIP} install --no-cache-dir \
Expand Down
Loading