fix(ci): include .tftest.hcl files in terraform fmt pre-commit hook#872
Open
fix(ci): include .tftest.hcl files in terraform fmt pre-commit hook#872
Conversation
gabebatista
approved these changes
Feb 16, 2026
The upstream terraform_fmt hook only matches .tf, .tofu, and .tfvars files. Override the files pattern to also match .tftest.hcl so that Terraform test files are formatted on commit, matching the CI check which runs `terraform fmt -check -recursive` on all file types.
hwkiem
force-pushed
the
fix/pre-commit-terraform-fmt-tftest
branch
from
a8627ab to
0fcf44c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filespattern on theterraform_fmtpre-commit hook to also match.tftest.hclfilesContext
The upstream
terraform_fmthook fromantonbabenko/pre-commit-terraformonly matches.tf,.tofu, and.tfvarsfiles. This means.tftest.hclfiles are not formatted by the pre-commit hook, but CI runsterraform fmt -check -recursivewhich catches all Terraform file types.This mismatch caused format check failures on #870 and #871 — the pre-commit hook passed locally but CI failed on unformatted test files.
Test plan
.tftest.hclfile with bad formatting and verify the pre-commit hook catches it