Add Netapp Ontap utils and custom tasks for horde#848
Add Netapp Ontap utils and custom tasks for horde#848MaorNetApp wants to merge 2 commits intoaws-games:mainfrom
Conversation
hwkiem
left a comment
There was a problem hiding this comment.
Just looking for slight tweaks and a different location in the project. Otherwise, looks good!
Thank you.
modules/unreal/horde/OntapUnrealEngine/Examples/CloneVolumeExample.xml
Outdated
Show resolved
Hide resolved
modules/unreal/horde/OntapUnrealEngine/Examples/DeleteVolumeExample.xml
Outdated
Show resolved
Hide resolved
| ## Files | ||
|
|
||
| **Tasks/** - C# BuildGraph task implementations | ||
| - `SyncAndSnapshotTask.cs` - Sync from Perforce and create ONTAP snapshot |
There was a problem hiding this comment.
Why create a new tasks for syncing and snapshotting as opposed to using the built in sync capabilities of Horde?
There was a problem hiding this comment.
In built in sync of horde it will create folder named the task we run, and in the folder the project will be inside /Sync/ProjectName.
So if we will clone the volume and mount it the project will be under /TaskName/Sync/Project
I can remove the sync task at all, but there will be other files except the project folder
what will be best approach of that ?
modules/unreal/horde/OntapUnrealEngine/Tasks/CloneVolumeTask.cs
Outdated
Show resolved
Hide resolved
modules/unreal/horde/OntapUnrealEngine/AutomationUtils/OntapUtils.cs
Outdated
Show resolved
Hide resolved
gabebatista
left a comment
There was a problem hiding this comment.
I think any concern I had was already addressed by Henry's comments. Thank you for your contribution!
Issue number:
Summary
Add NetApp utilities and a custom task for horde build graph scripts to sync data from Perforce to a mounted FSx volume, enabling snapshot creation and cloning for mounting on another EC2 instance.
Changes
Add folder OntapUnrealEngine with buildgraph scripts
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
No.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created might not be successful.