Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,6 @@ id_ed25519.pub

# Kiro context files
.kiro

# Claude Code configuration
CLAUDE.md
2 changes: 2 additions & 0 deletions modules/perforce/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -258,5 +258,7 @@ packer build perforce_x86.pkr.hcl
| <a name="output_p4_server_super_user_password_secret_arn"></a> [p4\_server\_super\_user\_password\_secret\_arn](#output\_p4\_server\_super\_user\_password\_secret\_arn) | The ARN of the AWS Secrets Manager secret holding your P4 Server super user's username. |
| <a name="output_p4_server_super_user_username_secret_arn"></a> [p4\_server\_super\_user\_username\_secret\_arn](#output\_p4\_server\_super\_user\_username\_secret\_arn) | The ARN of the AWS Secrets Manager secret holding your P4 Server super user's password. |
| <a name="output_shared_application_load_balancer_arn"></a> [shared\_application\_load\_balancer\_arn](#output\_shared\_application\_load\_balancer\_arn) | The ARN of the shared application load balancer. |
| <a name="output_shared_application_load_balancer_dns_name"></a> [shared\_application\_load\_balancer\_dns\_name](#output\_shared\_application\_load\_balancer\_dns\_name) | The DNS name of the shared application load balancer. |
| <a name="output_shared_application_load_balancer_zone_id"></a> [shared\_application\_load\_balancer\_zone\_id](#output\_shared\_application\_load\_balancer\_zone\_id) | The zone ID of the shared application load balancer. |
| <a name="output_shared_network_load_balancer_arn"></a> [shared\_network\_load\_balancer\_arn](#output\_shared\_network\_load\_balancer\_arn) | The ARN of the shared network load balancer. |
<!-- END_TF_DOCS -->
1 change: 1 addition & 0 deletions modules/perforce/modules/p4-code-review/elasticache.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ resource "aws_elasticache_subnet_group" "subnet_group" {

# Single Node Elasticache Cluster for P4 Code Review
resource "aws_elasticache_cluster" "cluster" {
#checkov:skip=CKV_AWS_134:Automatic backups not required for development/sample environments
count = var.existing_redis_connection != null ? 0 : 1
cluster_id = "${local.name_prefix}-elasticache-redis-cluster"
engine = "redis"
Expand Down
10 changes: 10 additions & 0 deletions modules/perforce/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ output "shared_application_load_balancer_arn" {
description = "The ARN of the shared application load balancer."
}

output "shared_application_load_balancer_dns_name" {
value = var.create_shared_application_load_balancer ? aws_lb.perforce_web_services[0].dns_name : null
description = "The DNS name of the shared application load balancer."
}

output "shared_application_load_balancer_zone_id" {
value = var.create_shared_application_load_balancer ? aws_lb.perforce_web_services[0].zone_id : null
description = "The zone ID of the shared application load balancer."
}

# P4 Server
output "p4_server_eip_public_ip" {
value = var.p4_server_config != null ? module.p4_server[0].eip_public_ip : null
Expand Down
6 changes: 3 additions & 3 deletions modules/teamcity/local.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ locals {
efs_file_system_arn = var.efs_id != null ? data.aws_efs_file_system.efs_file_system[0].arn : aws_efs_file_system.teamcity_efs_file_system[0].arn
efs_access_point_id = var.efs_access_point_id != null ? var.efs_access_point_id : aws_efs_access_point.teamcity_efs_data_access_point[0].id

# Service Connect namespace
service_connect_namespace_arn = aws_service_discovery_http_namespace.teamcity.arn

# TeamCity Server Information
# Set environment variables
base_env = [
Expand All @@ -40,9 +43,6 @@ locals {
value = local.database_master_password
}
] : []

# Service Connect namespace
service_connect_namespace_arn = aws_service_discovery_http_namespace.teamcity.arn
}
data "aws_region" "current" {}

Expand Down
Loading
Loading