fix: resolve race condition in test_adopt_or_create_policy e2e test

[a-hilaly]

The test was fetching bucket tagging before sleeping, then asserting
against the stale data. This caused flaky failures when the controller
hadn't finished applying tags yet, resulting in an empty tag_set.

Move the sleep before the Tagging() call so we wait for the controller
to apply tags, then fetch the current state for assertion.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[michaelhtm]

/lgtm

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[a-hilaly]

/retest

[a-hilaly]

/retest

[ack-prow]

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
s3-verify-code-gen	97bd10e	link	true	/test s3-verify-code-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.