Initial Implementation for DataSet resource#11
Merged
ack-prow[bot] merged 12 commits intoaws-controllers-k8s:mainfrom Mar 26, 2026
Merged
Initial Implementation for DataSet resource#11ack-prow[bot] merged 12 commits intoaws-controllers-k8s:mainfrom
ack-prow[bot] merged 12 commits intoaws-controllers-k8s:mainfrom
Conversation
Member
Author
|
/retest |
knottnt
reviewed
Mar 23, 2026
added 2 commits
March 25, 2026 23:10
knottnt
reviewed
Mar 25, 2026
knottnt
left a comment
knottnt
left a comment
There was a problem hiding this comment.
Overall looks good! Looks like the latest commit did unnecessarily change the release version though. Once that's reverted should be good to approve.
@a-hilaly @michaelhtm: Let me know if either if either of you would like to give this a second review before merging.
michaelhtm
approved these changes
Mar 26, 2026
Member
michaelhtm
left a comment
michaelhtm
left a comment
There was a problem hiding this comment.
This is great @gustavodiaz7722 👍
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gustavodiaz7722, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.