feat: support for IAM authentication mode for user#211
feat: support for IAM authentication mode for user#211stephensarabiasurion wants to merge 2 commits intoaws-controllers-k8s:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stephensarabiasurion The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @stephensarabiasurion. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test all |
|
@stephensarabiasurion: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @stephensarabiasurion thanks so much for the PR! Looks like some of the hooks aren't wired up properly. code-gen should handle that for you. Did you hand-edit files for this PR? ACK leverages code generation, so you should not need to edit files like sdk.go, types.go, etc We have contributor docs on the old docset, we prob need to update this. Can you try a reset and:
That should create the code, wire things up, and create your kustomize/helm artifacts for you. If all goes well, force push and we'll see where that lands? Holler if any of this doesn't make sense, thanks! |
Issue #, if available: aws-controllers-k8s/community#2356
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.