Skip to content

feat: support for IAM authentication mode for user#211

Open
stephensarabiasurion wants to merge 2 commits intoaws-controllers-k8s:mainfrom
stephensarabiasurion:feat/iam-auth-mode
Open

feat: support for IAM authentication mode for user#211
stephensarabiasurion wants to merge 2 commits intoaws-controllers-k8s:mainfrom
stephensarabiasurion:feat/iam-auth-mode

Conversation

@stephensarabiasurion
Copy link
Copy Markdown

Issue #, if available: aws-controllers-k8s/community#2356

Description of changes:

  • Removed AuthenticationMode field_paths from the ignore list
  • Updated the AuthenticationMode struct to pass in Type, in line with the ElastiCache CDK docs
  • New authenticationMode block in helm CRDs
  • Also added tests and doc for IAM authentication mode

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm April 2, 2026 20:05
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephensarabiasurion
Once this PR has been reviewed and has the lgtm label, please assign knottnt for approval by writing /assign @knottnt in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Apr 2, 2026

Hi @stephensarabiasurion. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Copy Markdown
Member

a-hilaly commented Apr 3, 2026

/test all

@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Apr 3, 2026

@stephensarabiasurion: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-code-gen 8df30dd link true /test elasticache-verify-code-gen
elasticache-kind-e2e 8df30dd link true /test elasticache-kind-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlbutler
Copy link
Copy Markdown
Member

jlbutler commented Apr 3, 2026

Hi @stephensarabiasurion thanks so much for the PR!

Looks like some of the hooks aren't wired up properly. code-gen should handle that for you.

Did you hand-edit files for this PR? ACK leverages code generation, so you should not need to edit files like sdk.go, types.go, etc

We have contributor docs on the old docset, we prob need to update this.
https://aws-controllers-k8s.github.io/community/docs/contributor-docs/overview/

Can you try a reset and:

  1. Update your ignores in generator.yaml (don't worry about apis/v1alpha1/generator.yaml, it gets built)
  2. add your AuthenticationMode handling to pkg/resource/user/hooks.go
  3. Rebuild — SERVICE=elasticache make -C code-generator build-controller

That should create the code, wire things up, and create your kustomize/helm artifacts for you. If all goes well, force push and we'll see where that lands? Holler if any of this doesn't make sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants