Web identity provider better handles error API responses #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry4n1m3
force-pushed
the
aws-web-identity-parse-errors
branch
from
c7c3430 to
a6ccc0f
Compare
onno-vos-dev
approved these changes
Nov 21, 2025
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the make_map function could raise an error if the XML response didn't contain the expected AccessKeyId or SecretAccessKey, which is the case if you get an error response from the api. This replaces that exception with a returned error tuple, allowing subsequent providers to attempt to auth and for the gen_server to start correctly.
We also pushed a few test credential expiration dates 10 years into the future to prevent them failing for a while ;)
Co-author: @JB2sf
Licensing:
This contribution is made by employees of Mechanical Orchard, Inc. under the terms of the project’s license.