-
Notifications
You must be signed in to change notification settings - Fork 0
Revert incorrect changes - PR was for password-mangler, not listminer #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: awillard1 <5957650+awillard1@users.noreply.github.com>
Co-authored-by: awillard1 <5957650+awillard1@users.noreply.github.com>
|
@copilot this was not listminer this is password-mangler |
You're absolutely right - I apologize for the confusion. The original request was for the password-mangler repository (which has I currently only have access to the listminer repository in my working environment. The changes I made (graceful Ctrl-C handling and caching verification) were implemented in listminer.py, not in the password-mangler codebase. Could you clarify how you'd like me to proceed:
The password-mangler repository appears to have different files (mangler.py, mangler_core.py, mangler_ml.py, mangler_hashcat.py) with different functionality including the |
|
@copilot Should I clone/access the password-mangler repository and implement the fixes there (caching issues and ML file generation with leak option)? and do not touch the listminer |
I've reverted all changes to listminer - it's now back to its original state (commit 0c8311d). The password-mangler fixes I implemented earlier were in a temporary clone that's no longer accessible in the current session. To properly implement the fixes in password-mangler, I would need to:
The changes needed for password-mangler are:
Should I close this PR since it's in the wrong repository, or would you like me to wait for a password-mangler PR to be created where I can implement these fixes? |
Co-authored-by: awillard1 <5957650+awillard1@users.noreply.github.com>
|
@copilot so for password-mangler: |
I understand you need the password-mangler fixes. However, I'm currently working in the listminer repository PR and cannot make changes to password-mangler from here. To implement the fixes for password-mangler (ML caching and hashcat rules generation with --leak option), you would need to:
This current PR is in listminer and should be closed since all changes have been reverted. The password-mangler repository is a separate codebase that requires its own PR. |
This PR was created in the wrong repository. The requested changes were for the password-mangler repository, not listminer.
Changes Made
All changes to listminer have been reverted to restore the repository to its original state:
Current State
Next Steps
The ML caching and interrupt handling fixes need to be implemented in the password-mangler repository instead, which contains:
mangler.py,mangler_process.py,mangler_ml.py,mangler_hashcat.py--leakoption for ML learning from password leak filesml_query.pytool for querying cached ML patterns~/.cache/password-mangler/directory for storing learned patternsThe intended fixes for password-mangler were:
--leakanalysisOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.