Major rework of all nearly types and many methods#3
Open
EbertPaul wants to merge 7 commits intoawietek:mainfrom
Open
Major rework of all nearly types and many methods#3EbertPaul wants to merge 7 commits intoawietek:mainfrom
EbertPaul wants to merge 7 commits intoawietek:mainfrom
Conversation
…, torus basis vectors) + tests
…istance_computation is not bullet-proof in all cases)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since from my experience 90% of bugs in such lattice calculations come from the erroneous usage of vectors in different bases, I introduced the
EuclideanVector(standard vector),LatticeVector(vector in terms of lattice basis), andFiniteLatticeVector(vector in terms of finite lattice / torus basis) types. Nearly all internal function and method signatures now rely on explicit types for these vectors, which should prevent a lot of undesired behavior and makes the code much more understandable in my opinion. Sadly, this nearly completely breaks compatibility with previous scripts, but I think this was necessary to properly developped this into a package. I made sure that there a usually many function-aliases with different parameter types (such as the different vectors) which are properly handelled.I also fixes all bugs currently known to me for 3D systems.
There is now a solid set of tests for the most important functionalities.
I (rather briefly) updated the examples and plotting functionalities.