Skip to content

Chapter page trustee list on mobile always shows trustee name; trustees only link if URL is set #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcn merged 1 commit into from
Feb 3, 2026
Merged

Chapter page trustee list on mobile always shows trustee name; trustees only link if URL is set #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 31 additions & 22 deletions app/assets/stylesheets/_chapters-show.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ body.chapters-show {

.title {
margin-right: 1.5em;
margin-left: 1.5em;
border-bottom: 1px solid rgb(200,200,200);
margin-left: 1.5em;
border-bottom: 1px solid rgb(200,200,200);
padding-bottom: 10px;

h1 {
Expand Down Expand Up @@ -96,7 +96,7 @@ body.chapters-show {
}
}
}

.owl-stage {
margin: 0 auto;
}
Expand Down Expand Up @@ -157,7 +157,7 @@ body.chapters-show {
opacity: 1;
}
}

.chapter-projects.touch-device {
.owl-nav-round button {
display: none !important;
Expand Down Expand Up @@ -208,7 +208,7 @@ body.chapters-show {
}
}


.chapter-projects {
white-space: nowrap;
overflow: hidden;
Expand Down Expand Up @@ -287,7 +287,7 @@ body.chapters-show {
border-bottom: 1px solid rgb(200,200,200);
}

.trustees {
.trustees {
padding-bottom: 40px;
margin-left: 1.5em;
margin-right: 1.5em;
Expand All @@ -298,7 +298,7 @@ body.chapters-show {
border-bottom: 1px solid rgb(200,200,200);
padding-bottom: 15px;
}

ol {
@extend .clearfix;
margin: 0px;
Expand Down Expand Up @@ -326,7 +326,6 @@ body.chapters-show {
article.trustee {
position: relative;

a {
text-decoration: none;

div.avatar {
Expand All @@ -341,7 +340,7 @@ body.chapters-show {
opacity: 0;
padding: 8px;
position: absolute;
top: 80px;
top: 100px;
max-width: grid-width(2);
z-index: 3;

Expand All @@ -368,24 +367,20 @@ body.chapters-show {
opacity: 1;
}
}
}

}

&:nth-child(even) {
a:hover {
.trustee-details {
left: -4px;
@include transform(rotate(-10deg));
}
.trustee-details {
left: -4px;
@include transform(rotate(-10deg));
}
}

&:nth-child(odd) {
a:hover {
.trustee-details {
left: -12px;
@include transform(rotate(7deg));
}
.trustee-details {
left: -12px;
@include transform(rotate(7deg));
}
}
}
Expand Down Expand Up @@ -483,11 +478,25 @@ body.chapters-show {
/* Responsiveness */
/**********************************************/

@media (hover: none) {
.chapter-info {
.trustees {
ol {
li article.trustee {
.trustee-details {
opacity: 1;
}
}
}
}
}
}

@media (max-width:31.1em) {
.chapter-info {
.trustees {
ol {
li {
li {
transform: scale(0.9);
}
}
Expand All @@ -506,4 +515,4 @@ body.chapters-show {
}
}
}
}
}
7 changes: 4 additions & 3 deletions app/views/chapters/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,16 @@
<% @chapter.users.deans_first.including_role.distinct.each do |user| %>
<li>
<article class="trustee <%= user.role %>">
<%= link_to user.url, :class => :avatar do %>
<% trustee_html = capture do %>
<div class="hat"></div>
<div class="trustee-details">
<h3><%= user.first_name %> <%= user.last_name %></h3>
<h3><%= user.first_name %> <%= user.last_name %><%= "&nbsp;➚".html_safe if user.url.present? %></h3>
</div>
<div class="avatar">
<%= image_tag user.gravatar_url, :alt => t(".trustees.photo-alt-text", :name => user.name) %>
</div>
<% end %>
<%= link_to_if user.url.present?, trustee_html, user.url, { target: "_blank", class: :avatar } %>
</article>
</li>
<% end %>
Expand All @@ -107,7 +108,7 @@
</div>
</section>
<% end %>

</div>

<% content_for :javascript do -%>
Expand Down