Skip to content

Feat sep.names#480

Open
iagogv3 wants to merge 4 commits intoawalker89:masterfrom
iago-ContributedForks:feat-sep.names
Open

Feat sep.names#480
iagogv3 wants to merge 4 commits intoawalker89:masterfrom
iago-ContributedForks:feat-sep.names

Conversation

@iagogv3
Copy link

@iagogv3 iagogv3 commented Aug 2, 2019

Feature for read.xlsx: sep.names allows choose other separator than '.' for variable names with a blank inside

iagogv added 4 commits August 2, 2019 17:29
  Rd file 'protectWorksheet.Rd':
    \examples lines wider than 100 characters:
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #480 into master will decrease coverage by 0.08%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
- Coverage   60.23%   60.14%   -0.09%     
==========================================
  Files          30       30              
  Lines        7142     7146       +4     
==========================================
- Hits         4302     4298       -4     
- Misses       2840     2848       +8
Impacted Files Coverage Δ
R/wrappers.R 42.61% <ø> (ø) ⬆️
src/openxlsx_init.c 0% <ø> (ø) ⬆️
src/read_workbook.cpp 90.61% <100%> (-0.33%) ⬇️
R/helperFunctions.R 75.56% <100%> (ø) ⬆️
R/workbook_read_workbook.R 88.88% <66.66%> (-0.38%) ⬇️
R/readWorkbook.R 82.94% <75%> (-0.15%) ⬇️
src/write_data.cpp 61.06% <0%> (-3.5%) ⬇️
src/write_file.cpp 88.57% <0%> (-0.09%) ⬇️
src/load_workbook.cpp 89.93% <0%> (-0.07%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead0038...168e4e8. Read the comment docs.

@ycphs
Copy link
Contributor

ycphs commented Oct 8, 2019

I implemented your PR in my new fork of the repository https://github.com/ycphs/openxlsx

@iagogv3
Copy link
Author

iagogv3 commented Oct 9, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants