Fixed extraction of sheet names and identification of sheets with comments#436
Open
heseber wants to merge 5 commits intoawalker89:masterfrom
heseber:master
Open
Fixed extraction of sheet names and identification of sheets with comments#436heseber wants to merge 5 commits intoawalker89:masterfrom heseber:master
heseber wants to merge 5 commits intoawalker89:masterfrom
heseber:master
Conversation
Some Excel files contain sheet names for veryHidden sheets that do not have any sheet content. Such sheets have an empty r:id. Their sheet names have to be skipped because otherwise there will be a misalignment between sheet names and sheet indeces.
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 60.23% 60.29% +0.05%
==========================================
Files 30 30
Lines 7142 7150 +8
==========================================
+ Hits 4302 4311 +9
+ Misses 2840 2839 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits fix two issues: