Extend setRowHeights to accept parameter(s) "auto"#382
Open
DavidBreuer wants to merge 2 commits intoawalker89:masterfrom
Open
Extend setRowHeights to accept parameter(s) "auto"#382DavidBreuer wants to merge 2 commits intoawalker89:masterfrom
DavidBreuer wants to merge 2 commits intoawalker89:masterfrom
Conversation
s439
approved these changes
Mar 2, 2020
Author
|
@s439 Thanks for the approval! I resolved the conflicts, so the PR should be ready to be merged. |
|
Thanks for the feature @DavidBreuer ! Hope it will be merged soon |
|
Thanks for this - I found it because I was searching for exactly this feature. Would be great to see this merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend setRowHeights to accept parameter(s) "auto" to automatically scale row heights. For long cell entries, the row height is automatically adjusted (and text wrapping enabled) so that all lines are visible.
The use of the "auto" parameter(s) is analogue to the setColWidths function:
setRowHeights(wb, sheet, rows = c(1, 2, 8, 4, 6), heights = c(30, "auto", 15, 15, 30))
The computation of the text width currently uses the basic strwidth function but can certainly be improved. For now I introduced a "factor" parameter to adjust the text width for different fonts or font families.