Fix null reference exception in AbstractionMapper.ToChatResponseUpdate #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaescher
approved these changes
Nov 14, 2025
Owner
|
Nice find, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a NullReferenceException that occurs in
AbstractionMapper.ToChatResponseUpdatemethod when processing streaming responses.Problem
When the Ollama API returns a response where
responseorresponse.Messageis null, the current implementation throws a NullReferenceException at:Solution
Added null-safe navigation operators to handle null responses gracefully:
ToAbstractionRole(response?.Message?.Role)
Testing
Related Issues
This issue was discovered while using OllamaSharp with Microsoft.Extensions.AI in production environments where occasional null responses from the Ollama API caused application crashes.