Skip to content

Fix chi2 zero bin #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jancervenka merged 2 commits into from
Mar 14, 2025
Merged

Fix chi2 zero bin #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a99e3be
fix chi2 zero bin
jancervenka Mar 14, 2025
7614521
bump
jancervenka Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tool]
[tool.poetry]
name = "ep-stats"
version = "2.5.4"
version = "2.5.5"
homepage = "https://github.com/avast/ep-stats"
description = "Statistical package to evaluate ab tests in experimentation platform."
authors = [
Expand Down
10 changes: 5 additions & 5 deletions src/epstats/toolkit/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,13 +261,13 @@ def evaluate_agg(self, goals: pd.DataFrame, default_exp_variant_id: str) -> pd.D

stat, pval = chisquare(
f_obs=[
denominator_counts.sum(),
nominator_counts.sum(),
denominator_counts.sum() + 1,
nominator_counts.sum() + 1,
],
f_exp=[
denominator_counts.sum() + nominator_counts.sum(),
0,
]
denominator_counts.sum() + nominator_counts.sum() + 1,
1,
],
)
r = pd.DataFrame(
{
Expand Down
4 changes: 2 additions & 2 deletions src/epstats/toolkit/testing/resources/evaluations_checks.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,12 @@ test-multi-dimension,1,SRM,confidence_level,0.999
test-sum-ratio,1,EVA,sum_ratio,0.19607843137254902
test-sum-ratio,1,EVA,max_sum_ratio,0.01
test-sum-ratio,1,EVA,p_value,0.0
test-sum-ratio,1,EVA,test_stat,inf
test-sum-ratio,1,EVA,test_stat,9000491.7764
test-sum-ratio,1,EVA,confidence_level,0.999
test-multi-check,1,EVA,sum_ratio,0.19607843137254902
test-multi-check,1,EVA,max_sum_ratio,0.01
test-multi-check,1,EVA,p_value,0.0
test-multi-check,1,EVA,test_stat,inf
test-multi-check,1,EVA,test_stat,9000491.7764
test-multi-check,1,EVA,confidence_level,0.999
test-multi-check,2,SRM,p_value,0.140747987
test-multi-check,2,SRM,test_stat,3.9215686
Expand Down