set concurrency to 1 #3
Conversation
avaer
left a comment
avaer
left a comment
There was a problem hiding this comment.
This seems to regress the core parallel install functionality of this module. If we're going to add concurrency configuration, it should be taken in as an argument, not hard coded to 1. Otherwise a large part if the point of using archae in the first place is lost.
| /node_modules | ||
| /example/installed | ||
| /example/data | ||
| .idea/ No newline at end of file |
There was a problem hiding this comment.
This seemingly has nothing to do with setting concurrency to 1, so it shouldn't be in this PR right?
| const watchr = require('watchr'); | ||
| const cryptoutils = require('cryptoutils'); | ||
| const MultiMutex = require('multimutex'); | ||
| var bluebird = require('bluebird'); |
There was a problem hiding this comment.
Can we avoid this bluebird dependency? This seems a huge thing to use when the equivalent promise looper is probably 5 lines of code.
Also we have the multimutex module already included, which solves this exact concurrency problem.
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/modulesio/archae.git" | ||
| "url": "https://github.com/toomu/archae.git" |
There was a problem hiding this comment.
Was it deliberate to take over the repo in npm?
There was a problem hiding this comment.
I dont have permissions to write to https://github.com/modulesio/archae.git . Thought that implied I need to fork it to make the changes
There was a problem hiding this comment.
Yeah, but with this change the whole repo would point to toomu/archae from now on in npm. I'm really not sure what the point of that would be.
If this is for testing, it probably shouldn't be committed, or at least should not be part of a PR.
Though I'm not quite sure how this helps in testing in the first place...
| @@ -7,9 +7,10 @@ | |||
| }, | |||
There was a problem hiding this comment.
The npm version probably needs to change to please package manager and deployment systems.
2 participants
No description provided.