Upgrade Substrate (with core-evm-relay removed)#1549
Merged
Conversation
Member
Author
|
Fixed docs |
fa456c8 to
11f31dc
Compare
11f31dc to
7fdbd88
Compare
ParthDesai
previously approved these changes
Jun 16, 2023
vedhavyas
previously approved these changes
Jun 16, 2023
Contributor
After this PR is merged, I will add support for testing the |
NingLin-P
previously approved these changes
Jun 16, 2023
rahulksnv
previously approved these changes
Jun 16, 2023
The base branch was changed.
i1i1
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Jun 23, 2023
0xjeremyfrank
pushed a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the most minimal update possible just to make it compile without warnings and produce blocks. There will be subsequent PR with more dependencies updated.
core-evm-relayis not useful anymore and was very hard to upgrade, so it had to go.There are some breaking changes and I highly recommend to at least go through the list of mentioned PRs. In our fork I did rebase (which did not require major refactoring).
If you can test some of the domains and other stuff with this PR that'd be awesome.
Some interesting/notable/relevant upstream Substrate PRs:
sc-networkforProtocolController/NotificationServiceparitytech/substrate#14080type MigrationstoConfigparitytech/substrate#14309Snowbridge (eventually
core-eth-relaywas removed):Frontier:
pallet-timestampfrompallet-evmandpallet-ethereumpolkadot-evm/frontier#1050Breaking changes:
std::time::Duration(it is caused by ImplementTypeInfoforDurationparitytech/scale-info#183 for which I sent a PR, butDurationis serialized into(u64, u32), which is excessive for us and requires extra conversions down the line anyway)serdeserialization insp-domainswas not usingcamelCasenaming for fields (idiomatic in JSON), I changed it to do that nowcore-eth-relaywas removed due to seeming uselessness and difficulty of upgradetest_cross_domains_message_should_worktest was commented-out due to dependency oncore-eth-relayCode contributor checklist: