Skip to content

Fix many NaNs in conditional parameter-spaces#121

Draft
shukon wants to merge 1 commit intodevelopmentfrom
fix/lpi_handles_nan
Draft

Fix many NaNs in conditional parameter-spaces#121
shukon wants to merge 1 commit intodevelopmentfrom
fix/lpi_handles_nan

Conversation

@shukon
Copy link
Collaborator

@shukon shukon commented May 9, 2020

When using conditionals, there might be nan-values... rendering the importance of an entire parameter useless. On the other hand, this solution might consider some parameters more than others by reducing the considered values? I am not sure how to handle this, @AndreBiedenkapp

@AndreBiedenkapp
Copy link
Collaborator

I thought the way the neighbors are sampled only allows for valid configurations in LPI.
Has something changed in the config space or am I simply mistaken?

But to give you an idea of how conditionals are handled in the other methods. In ablation we handle conditionals by jointly flipping them with their parent parameter. And then we attribute the importance to that tuple and not one individual parameter.
AFAIK fANOVA ignores conditionals entirely and pretends they are just normal parameters.

@shukon
Copy link
Collaborator Author

shukon commented May 10, 2020

Well, the NaN's might have a different reason. I will investigate further...

@shukon shukon marked this pull request as draft May 10, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants