Fix many NaNs in conditional parameter-spaces#121
Draft
shukon wants to merge 1 commit intodevelopmentfrom
Draft
Conversation
Collaborator
|
I thought the way the neighbors are sampled only allows for valid configurations in LPI. But to give you an idea of how conditionals are handled in the other methods. In ablation we handle conditionals by jointly flipping them with their parent parameter. And then we attribute the importance to that tuple and not one individual parameter. |
Collaborator
Author
|
Well, the NaN's might have a different reason. I will investigate further... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using conditionals, there might be nan-values... rendering the importance of an entire parameter useless. On the other hand, this solution might consider some parameters more than others by reducing the considered values? I am not sure how to handle this, @AndreBiedenkapp