Conversation
amsks
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #87 by using a larger batch sizes (at least as far as I can see!) and also adds tests for reproducibility. These failed because we were good and used local seeding in most components, but obviously global seeds don't touch them. That's changed now and everything runs.
Because of local install issues using python 3.10, I upgraded the version to 3.11. The issue with 3.10 are lower jax and flax versions that cause problems in CARL. Since 3.10 is older now anyway, this is probably not an issue.
Also, since that test was failing locally, I ended up cleaning the configs since there was a bad ref somewhere. This means this fixes #79 as well.