Fraud Alert Validation Service#32
Open
nathjaco1016 wants to merge 17 commits intoautomationExamples:mainfrom
Open
Fraud Alert Validation Service#32nathjaco1016 wants to merge 17 commits intoautomationExamples:mainfrom
nathjaco1016 wants to merge 17 commits intoautomationExamples:mainfrom
Conversation
…, wrote specs for the transaction endpoints + tests for fraud alerts. Also added .claude/settings.json to create gaurdrails to keep claude within a defined set of behavior that I use for all my projects.
…erly define how transactions will work. I will fully implement pii masking later on in the project.
…s, the tests passed successfully.
…ing. We will revisit GET /alerts masking after we finish the filtering functionality in the future.
…d after some parameter issues.
…g fraud alerts. Wrote tests and ensured that they pass.
…s. I also added a new README.md to explain the project and how to run/test it. Made final changes to tests to ensure that they are specific and understandable. Modified the git ignore so that the db I was testing with won't be included in the PR. I also tested via the docs thoroughly to make sure everything works well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This project is essentially a REST API for storing fraud alerts, enforcing lifecycle transitions, and properly handling customer data to comply with Ally's PII sensitivity principles.
I put everything in fraud-alert-service to keep the project separated from the given spec-driven-dev environment.
Specs
I created specs for transactions (CRUD for records with field validation), alerts, state machine, PII masking, filtering, and summary stats.
Tech Stack
I used FastAPI, Pydantic v2, SQLite, and pytest + httpx.
Test Coverage
142 tests across 6 test files, each corresponding to a spec.
Spec Driven Development
I have experience with spec driven development, so I essentially just used my standard workflow where I broke down my project into specs and wrote these out myself, used Claude to review these and enhance them if necessary (it's good at finding edge cases and such that I may have missed), then I added actionable TODO tasks before implementation.
Code Gen Tool Used
I used Claude as my primary code generation tool.