Skip to content

fix: extension build and loading states#408

Merged
RonenMars merged 1 commit intomainfrom
ronen/fix/fix-build-and-performance
Oct 16, 2025
Merged

fix: extension build and loading states#408
RonenMars merged 1 commit intomainfrom
ronen/fix/fix-build-and-performance

Conversation

@RonenMars
Copy link
Collaborator

Description

Linear Ticket

What type of PR is this? (check all applicable)

  • 💡 (feat) - A New Feature (non-breaking change which adds functionality)
  • 🔄 (refactor) - Code Refactoring - A code change that neither fixes a bug nor adds a feature
  • 🐞 (fix) - Bug Fix (non-breaking change which fixes an issue)
  • 🏎 (perf) - Optimization
  • 📄 (docs) - Documentation - Documentation only changes
  • 📄 (test) - Tests - Adding missing tests or correcting existing tests
  • 🎨 (style) - Styles - Changes that do not affect the meaning of the code (white spaces, formatting, missing semi-colons, etc)
  • ⚙️ (ci) - Continuous Integrations - Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • ☑️ (chore) - Chores - Other changes that don't modify src or test files
  • ↩️ (revert) - Reverts - Reverts a previous commit(s).

Code Standards

  • Notify only when user attention is needed, otherwise log to console.
    • Notifications: short description with context identifiers (e.g. id of the manipulated entity).
    • Logs: full description with full context identifiers (e.g. deploymentId and the relevant projectId).
  • If you're not sure what is the proper behavior, consult with the product team.
  • Reduce the use of else by employing early returns to make code more readable and less nested.
  • MVC Separation: Ensure separation of concerns; views should only be manipulated by controllers (also the computing - sorting, fitlering, etc.), not by services, to maintain a clean MVC architecture.
  • Before implementing custom logic, check if existing functions or utilities (like lodash) offer a simpler solution.
  • Avoid using !important in CSS where possible.
  • Use memoization for class calculations.
  • Place constant strings in your code using I18n.

@RonenMars RonenMars merged commit fa53b85 into main Oct 16, 2025
1 check passed
@github-actions
Copy link

🎉 This issue has been resolved in version 0.20.23 🎉

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants